Daniel Lu

Results 94 comments of Daniel Lu

Thanks for the repro steps @deebov, will need to investigate why that line that @snowystinger linked doesn't seem to be handling this situation properly

provisional approval for the changes @snowystinger made, can't approve my own PR though haha

I believe this is in the same vein as https://github.com/adobe/react-spectrum/issues/2333, essentially we have a double render that breaks logic that handles opening the menu automatically on input change. For our...

@undavide Allowing the `form` attribute on a button seems pretty reasonable, lemme double check with the team just in case.

Mind expanding on what cursor tracking is being done in the example you linked? Could you use `onInput` or `onBeforeInput` instead? EDIT: ah is it to calculate where to place...

@jluyau brought this one up with me actually, here is a modified sandbox from our discussion: https://codesandbox.io/s/jovial-orla-uig0f?file=/src/App.js. The issue is that the sort description can end up being populated without...

Some initial progress/potential fix on https://github.com/adobe/react-spectrum/tree/issue_2071. Bit iffy on the filter change, also investigating the ordering if a new droppable element is added after initial render EDIT: if a new...

Retested, verified that the closest droppable element is focused first when a drag is started via keyboard but the tab order is somewhat unexpected: https://reactspectrum.blob.core.windows.net/reactspectrum/cd0376c480ef7f554ea0aebac6669f28fa87740a/storybook/index.html?path=/story/drag-and-drop--nested-drop-regions&providerSwitcher-toastPosition=bottom. If you trigger keyboard dnd...

Cleaned up the new lint warnings, thanks @reidbarber for catching those. The orientation one is handled https://github.com/adobe/react-spectrum/pull/2362

With the comment made with https://github.com/adobe/react-spectrum/pull/2445#issuecomment-1150536157, I think the fix we'll want to implement is to prevent focus from moving to a closed scope's previously focused node if a sibling...