react-spectrum icon indicating copy to clipboard operation
react-spectrum copied to clipboard

Clean up all lint warnings

Open snowystinger opened this issue 3 years ago โ€ข 19 comments

Our lint warnings are getting away from us, this is a start to clean that up so that we can catch meaningful problems. Add comments explaining why some are disabled/not needed

Closes

โœ… Pull Request Checklist:

  • [ ] Included link to corresponding React Spectrum GitHub Issue.
  • [ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • [ ] Filled out test instructions.
  • [ ] Updated documentation (if it already exists for this component).
  • [ ] Looked at the Accessibility Practices for this feature - Aria Practices

๐Ÿ“ Test Instructions:

๐Ÿงข Your Project:

snowystinger avatar Oct 28 '20 00:10 snowystinger

Build successful! ๐ŸŽ‰

adobe-bot avatar Oct 28 '20 00:10 adobe-bot

Build successful! ๐ŸŽ‰

adobe-bot avatar Oct 28 '20 00:10 adobe-bot

Build successful! ๐ŸŽ‰

adobe-bot avatar Nov 11 '20 00:11 adobe-bot

Build successful! ๐ŸŽ‰

adobe-bot avatar Dec 05 '20 01:12 adobe-bot

Build successful! ๐ŸŽ‰

adobe-bot avatar Dec 07 '20 21:12 adobe-bot

Build successful! ๐ŸŽ‰

adobe-bot avatar Dec 08 '20 00:12 adobe-bot

Build successful! ๐ŸŽ‰

adobe-bot avatar Dec 08 '20 00:12 adobe-bot

Build successful! ๐ŸŽ‰

adobe-bot avatar Dec 08 '20 00:12 adobe-bot

Build successful! ๐ŸŽ‰

adobe-bot avatar Dec 08 '20 21:12 adobe-bot

Build successful! ๐ŸŽ‰

adobe-bot avatar Dec 08 '20 21:12 adobe-bot

Build successful! ๐ŸŽ‰

adobe-bot avatar Feb 22 '21 22:02 adobe-bot

Build successful! ๐ŸŽ‰

adobe-bot avatar Apr 09 '21 20:04 adobe-bot

Build successful! ๐ŸŽ‰

adobe-bot avatar Jun 18 '21 00:06 adobe-bot

Build successful! ๐ŸŽ‰

adobe-bot avatar Sep 01 '21 21:09 adobe-bot

Build successful! ๐ŸŽ‰

adobe-bot avatar Sep 21 '21 20:09 adobe-bot

Cleaned up the new lint warnings, thanks @reidbarber for catching those. The orientation one is handled https://github.com/adobe/react-spectrum/pull/2362

LFDanLu avatar Sep 21 '21 21:09 LFDanLu

Build successful! ๐ŸŽ‰

adobe-bot avatar Sep 23 '21 17:09 adobe-bot

Build successful! ๐ŸŽ‰

adobe-bot avatar Sep 23 '21 17:09 adobe-bot

Build successful! ๐ŸŽ‰

adobe-bot avatar Sep 23 '21 20:09 adobe-bot

closing due to https://github.com/adobe/react-spectrum/pull/3612

snowystinger avatar Oct 14 '22 17:10 snowystinger