Daniel Lu

Results 94 comments of Daniel Lu

Rough code flow: 1. [setTableWidth](https://github.com/adobe/react-spectrum/blob/e514827f49696a9c20fb819bd9610651f7017039/packages/%40react-stately/table/src/useTableColumnResizeState.ts#L120-L128) is computed every render. It makes use of `columns` obtained from `state`(i.e. state.collection from useTableState) which isn't a problem so long as you use the...

Apologies about the delayed response, the team still hasn't picked up nested menus due to other component priorities. We're are also still waiting on some additional design/a11y support for certain...

@uraway mind sharing what you are trying to accomplish with UNSAFE_className here? If this is for an Adobe product, then we wanna be careful with any styling overrides. If not,...

@IIIristraM mind signing the CLA as well?

Mind attaching a rough codesandbox of your setup here? If I'm reading this correctly, the container of your Dialog is being aria-hidden when opened? Is the setup roughly like the...

If I had to guess, that aria-hidden is being set by `ariaHideOutside` but that should only be hiding content outside the active modal. Since this behavior isn't broken in the...

+1 to what @ktabors mentioned. I think a specific callout to the "If the label is hidden, an icon is required, and the label will appear in a tooltip" portion...

right, we currently rely on the user to provide the tooltip... Is the tooltip mandatory for icon only buttons? If so, we could wrap it in a TooltipTrigger for the...

We didn't have any use cases for this scenario from Spectrum Design, mind bringing this case up with them? In the meantime you can probably use UNSAFE_className to apply your...

The team discussed this today, we'd be ok with exporting TableCollection and TableKeyboardDelegate as well as expanding the stately hooks so that they accept a pre-built `collection`. We don't have...