react-spectrum icon indicating copy to clipboard operation
react-spectrum copied to clipboard

(WIP) Preventing extraneous click on the wrong element when tapping on overlay elements

Open LFDanLu opened this issue 2 years ago โ€ข 7 comments

Closes https://github.com/adobe/react-spectrum/issues/1513

โœ… Pull Request Checklist:

  • [ ] Included link to corresponding React Spectrum GitHub Issue.
  • [ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • [ ] Filled out test instructions.
  • [ ] Updated documentation (if it already exists for this component).
  • [ ] Looked at the Accessibility Practices for this feature - Aria Practices

๐Ÿ“ Test Instructions:

Follow descriptions in new stories useModal/issues Click through modals Date and Time/DatePicker/issues Click through calendar MenuTrigger menu overlapping buttons

๐Ÿงข Your Project:

RSP

LFDanLu avatar Mar 10 '22 01:03 LFDanLu

Build successful! ๐ŸŽ‰

adobe-bot avatar Mar 10 '22 02:03 adobe-bot

Build successful! ๐ŸŽ‰

adobe-bot avatar Mar 11 '22 00:03 adobe-bot

provisional approval for the changes @snowystinger made, can't approve my own PR though haha

LFDanLu avatar Mar 11 '22 20:03 LFDanLu

Do we want to do separate testing of just this branch before we merge it? Are there any cases we've missed that would be good to cover in a story?

snowystinger avatar Mar 12 '22 00:03 snowystinger

Build successful! ๐ŸŽ‰

adobe-bot avatar Mar 16 '22 23:03 adobe-bot

Build successful! ๐ŸŽ‰

adobe-bot avatar Mar 16 '22 23:03 adobe-bot

Build successful! ๐ŸŽ‰

adobe-bot avatar Mar 23 '22 18:03 adobe-bot

Hello! Have any progress for this PR?

yarastqt avatar May 22 '23 14:05 yarastqt

@yarastqt Unfortunately haven't been able to pick this back up due to other priorities. If others would like to pick this up in the interim, that would be much appreciated!

LFDanLu avatar May 22 '23 16:05 LFDanLu

Closing for now until we pick this back up in our priorities.

LFDanLu avatar May 24 '23 19:05 LFDanLu