Daniel Lu

Results 94 comments of Daniel Lu

@reidbarber thats weird, are you able to reproduce it consistently? I saw this happen a long while ago I think but couldn't reproduce it, I can take another look

@reidbarber From what I can tell, https://github.com/adobe/react-spectrum/blob/main/packages/@react-aria/virtualizer/src/useVirtualizerItem.ts#L39-L46 is returning equal heights for each card div when this bug happens. Still poking around to see if this is something related to...

This is a regression on our part, thanks for catching this!

This is intentional behavior, the RangeCalendar displays a "selected" range when moving to different months as a visual affordance reminding the user that a range selection is in progress.

Discussed in slack, seems to be in a similar vein to the issues we had previously encountered in TableView with https://github.com/adobe/react-spectrum/pull/1875 and https://github.com/adobe/react-spectrum/pull/2059. Would be good if we only rerender...

@upender7270 The sandbox @snowystinger attached is actually working as expected, clicking on the background to blur the button removes the focus styles properly. Can you provide your own sandbox reproducing...

Test app now has a bunch more components (but not all, I'll add more in the future if we are cool with the setup)

@ktabors > Not sure if this running on the master branch in CI is the best. By that point it is too late because the docs change was deployed. Actually...

Looks like something broke when attempting to build the docs w/ verdaccio since the last release, will need to dig

Strange that the codesandbox doesn't reproduce the issue, but adding a null check to the line you linked makes sense. Just a fyi: I've removed the JIRA link since we...