Daniel Lu

Results 94 comments of Daniel Lu

@melcherry98 Since we aren't able to reproduce it via a codesandbox, would you mind trying to apply your suggested fix locally just to double check that it resolves the issue?...

Thanks for reporting this, looks like we missed localizing the TimeField label in general.

TODOs: - add tests for the new drag type/File/Directory filtering we've added to defaultOnDrop - Address https://github.com/adobe/react-spectrum/pull/3266#discussion_r964190132 - add controls to the ListView story so we can turn on/off the...

@stephenh I don't believe there is a ticket created for the tag field yet since it is still in its early germination phase unfortunately. https://github.com/adobe/react-spectrum/projects/1 is the best place to...

@reidbarber here are the errors I saw in the console: I was able to get it to load in a incog window and then by turning off some of my...

Another line of interest: https://github.com/adobe/react-spectrum/blob/main/packages/@react-stately/numberfield/src/useNumberFieldState.ts#L108 IMO we should check if `numberValue == null` and call `setInputValue` with to "" in that case perhaps

We'll also need to check for other areas where we do a similar NaN check and account for those as well.

At the moment none that I know of, short of using something like [patch package](https://www.npmjs.com/package/patch-package) to patch the bug locally. EDIT: @snowystinger has reminded me that you can use `NaN`...

Your hunch is correct, creating your own custom theme would require reproducing the set of variables/tokens that our Spectrum themes have and replacing the values with your own colors (e.g....

I'd like to just reiterate that the preferable approach would be to use the aria/stately hooks to recreate the components you need so that you can have full control over...