react-spectrum
react-spectrum copied to clipboard
adobe
Verdaccio script and CI build w/ verdaccio packages
Closes https://github.com/adobe/react-spectrum/issues/2389
✅ Pull Request Checklist:
- [ ] Included link to corresponding React Spectrum GitHub Issue.
- [ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
- [ ] Filled out test instructions.
- [ ] Updated documentation (if it already exists for this component).
- [ ] Looked at the Accessibility Practices for this feature - Aria Practices
📝 Test Instructions:
🧢 Your Project:
RSP
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Test app now has a bunch more components (but not all, I'll add more in the future if we are cool with the setup)
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
@ktabors
Not sure if this running on the master branch in CI is the best. By that point it is too late because the docs change was deployed.
Actually it would be ok since the docs changes that get deployed are built off the currently published packages so the verdaccio built docs would show what the docs WILL look like upon the next release. This is because the currently published packages are behind what is on main since main hasn't been released yet
It wasn't obvious from this PR how to run it locally, but that ended up being easy, ./scripts/verdacio.sh in one command line tab as running process (localhost:4000) and make website-production in a second command line tab once verdacio is up. You'll need to run a python (python -m SimpleHTTPServer 8080) or node http server (http-server) from the docs directory (dist/production/docs).
Haha, good point and thanks for testing it with me on your local machine. If we are ok with this script I'll go ahead and add some documentation somewhere with the same steps you listed above
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
* [View the storybook](https://reactspectrum.blob.core.windows.net/reactspectrum/7be2aa7bcb867edf4dd3a47b962d98f2305b2d03/storybook/index.html)
* [View the storybook-17](https://reactspectrum.blob.core.windows.net/reactspectrum/7be2aa7bcb867edf4dd3a47b962d98f2305b2d03/storybook-17/index.html)
* [View the documentation](https://reactspectrum.blob.core.windows.net/reactspectrum/7be2aa7bcb867edf4dd3a47b962d98f2305b2d03/docs/index.html)
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Looks like something broke when attempting to build the docs w/ verdaccio since the last release, will need to dig
Build successful! 🎉
Build successful! 🎉