react-spectrum
react-spectrum copied to clipboard
adobe
CardView docs
Closes #2729
✅ Pull Request Checklist:
- [ ] Included link to corresponding React Spectrum GitHub Issue.
- [ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
- [ ] Filled out test instructions.
- [ ] Updated documentation (if it already exists for this component).
- [ ] Looked at the Accessibility Practices for this feature - Aria Practices
📝 Test Instructions:
🧢 Your Project:
RSP
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
@reidbarber thats weird, are you able to reproduce it consistently? I saw this happen a long while ago I think but couldn't reproduce it, I can take another look
@reidbarber thats weird, are you able to reproduce it consistently? I saw this happen a long while ago I think but couldn't reproduce it, I can take another look
Interestingly, I'm getting a mix of the first and second image's layout when I refresh, and can't seem to find a pattern. My guess is that it's some race condition with the order that the images are loaded. Still weird that it would change when a selection is made though. This was at 1920x1080 btw. Also tried a mix of refreshing and hard refreshing.
@reidbarber From what I can tell, https://github.com/adobe/react-spectrum/blob/main/packages/@react-aria/virtualizer/src/useVirtualizerItem.ts#L39-L46 is returning equal heights for each card div when this bug happens. Still poking around to see if this is something related to the images loading or something else