react-spectrum
react-spectrum copied to clipboard
Unable to use `UNSAFE_className` on `ContextualHelp`
๐ Bug Report
UNSAFE_className
is mentioned on ContextualHelp
page, but user's UNSAFE_className
is always overridden by built-in className.
๐ค Expected Behavior
ActionButton on ContextualHelp styles can be customized with UNSAFE_className
.
๐ฏ Current Behavior
https://github.com/adobe/react-spectrum/blob/main/packages/%40react-spectrum/contextualhelp/src/ContextualHelp.tsx#L53
๐ Possible Solution
Like other components, it should merge user's UNSAFE_className
with built-in styles.
๐ฆ Context
๐ป Code Sample
๐ Your Environment
Software | Version(s) |
---|---|
react-spectrum | 3.21.2 |
Browser | |
Operating System |
๐งข Your Company/Team
๐ท Tracking Issue (optional)
Yep, looks like it's not applied anywhere https://codesandbox.io/s/optimistic-worker-ti0tzb?file=/src/App.js
@uraway mind sharing what you are trying to accomplish with UNSAFE_className here? If this is for an Adobe product, then we wanna be careful with any styling overrides. If not, then it should be fine.