Tomasz Chabora comments

Results 934 comments of


                                            Tomasz Chabora

[4.0] EditorSpinSlider won't close input when pressing TAB

> Pressing TAB won't close EditorSpinSlider's value-input control Seems to be still true. You need to press Enter and then you can tab.

Propagate previously unused NOTIFICATION_WORLD_2D_CHANGED, make CanvasItem/CollisionObject2D use it

IMO the PR is fine in the current form. It's too late to change the 3D side, so we'll have to live with inconsistency I guess.

Propagate previously unused NOTIFICATION_WORLD_2D_CHANGED, make CanvasItem/CollisionObject2D use it

Squash everything into 1 commit.

Allow more than one EditorPlugin per addon, support GDExtension classes

Needs rebase. Also might be worth splitting this in 2 PRs if GDExtension part has some concerns.

When quitting the editor to the project list, editor settings are lost

Can anyone reproduce this in 4.0 alpha? I never had this happen.

Godot 4.0 Terrain tiles not updating

There are a couple of proposals, but idk if they count as solid: https://github.com/godotengine/godot-proposals/issues/7670 https://github.com/godotengine/godot-proposals/issues/5575

Tree refactor

Status update: the progress was very slow, because I don't work on this consistently and recently I've been thinking about abandoning it. Originally I thought that I could just move...

Accessing a member variable before declaring a variable that would overshadow returns null

There is already a warning about shadowing method/variable names (the example code here shows one too), so the solution is to not use conflicting names,

Sprite with shader that modifies COLOR ignores modulate property

It works in the original overly-simplified example case, but for any other shader that actually does something with colors this will break.

Sprite with shader that modifies COLOR ignores modulate property

Knowing how it works in 4.0, I adjusted my old shaders and was able to successfully fix most of them. However in one shader I absolutely needed the modulate to...