[4.0] EditorSpinSlider won't close input when pressing TAB

[zaevi]

Godot version

master (target=debug)

System information

Windows 10

Issue description

Pressing TAB won't close EditorSpinSlider's value-input control, and sometimes it can't change focus.

It could be related to EditorSpinSlider::_focus_entered() as #53830 fixes.

Steps to reproduce

press tab button

Minimal reproduction project

No response

[EricEzaM]

Related #41691

[zaevi]

https://github.com/godotengine/godot/blob/9988c28edd77fba6e870280c047ae0d5128350e0/editor/editor_spin_slider.cpp#L625-L645

There is a Popup (inherited from Viewport for now) between EditorSpinSlider and its value-input control to perform popup() in replace of value-input's show_modal() in 3.x. Since Popup is not a Control but a Viewport in 4.0, the value-input control is in different viewport and can't handle releasing focus correctly.

~It's not necessary to use a popup to handle value-input's visibility and it should be removed.~ EDIT: The popup handles not only visibility but other modal behaviors, so it's not easy to remove.

[KoBeWi]

Pressing TAB won't close EditorSpinSlider's value-input control

Seems to be still true. You need to press Enter and then you can tab.

[YuriSizov]

Should be fixed by https://github.com/godotengine/godot/pull/71271.