KevinOConnor

Thanks. It looks fine to me. If there are no further comments I'll look to commit in a few days. I guess I'll look to do a "squash and merge"....

Thanks. I committed this change. I was just giving a few days to see if others had comments. Cheers, -Kevin

Thanks. I'm not sure what the intent of this change is, but at first glance I don't think it should be implemented this way. At a high-level, it is the...

FYI, heater updates are already tightly synchronized. I don't think generic output_pin (nor similar) should introduce synchronization as it's not clear all users would want that. I can see where...

Sorry - this "slipped" on my side. We can certainly change the documentation, but for what it is worth I find the paragraph flow of this change a little odd....

Thanks. I guess my main feedback would be that it is really hard to judge if this change would be a net improvement across the entire range of 3d printers...

> Wouldn't the Wikipedia description of the two algorithms support a conclusion opposite to yours, since it highlights general issues with the current algorithm? No. The PID algorithm is a...

Interesting, thanks. I'm not sure I understand the changes to toolhead.py. Can you elaborate on what they do and why they are needed? As a general observation, it seems a...

Thanks for the additional information. Sorry for the delay in responding. In general it looks good to me. > I hope you'd agree that the current mainline behavior is technically...

Thanks. In general it looks good. I have a few minor comments/suggestions: 1. Could we move "toolhead: Fixed junction deviation calculation for straight segments" to a separate PR? I'm concerned...