JosJuice
JosJuice
When you fix formatting errors or other minor mistakes from earlier in the PR, please do it by amending the commit where the problem was introduced.
With this change, if the state is Stopping, I don't believe we have any guarantee that the event will actually run.
You aren't checking `carry` in the a == 0 case. ~~(Note that this code only will run if constant propagation is disabled.)~~ EDIT: Disregard that last part, it can run...
Qt automatically selects the ordering of the buttons depending on what's customary on the user's operating system. I don't think there's sufficient reason to interfere with that.
> Was unsure if I should still pass the `outfile_path` and use it for the error messages, or just change the error messages to indicate that the file is a...
What's the reason you would like to add this? Personally I don't really see what it would be used for.