JosJuice

Results 236 comments of JosJuice

Since the license has changed, please update Externals/licenses.md.

I think forking a dependency just for the sake of general cleanup is unnecessary. We also don't have the capacity to review 1800 lines of minor changes.

As we previously explained to you, there was no vulnerability in the code you changed in PR #13169. Because of that, PR #13169 is just a minor modernization change, which...

Please don't put merge commits in PRs. Rebase the PR instead.

Which part went wrong? If it was the pushing part, make sure you're using force push.

I agree that it could make sense splitting that out to a separate PR. But I'm almost done with the review process of this PR, so I feel that it's...

LGTM after squashing into one commit.

She should be the one to decide that. But sure, I can do the squashing if needed.

Geotale reminded me that there's something that's not done: Making sure AArch64 and x64 have the same behavior in the fres special path (see the discussion in PR #13059 for...

An APK is already available from the buildbot. Click on the "pr-android" build check. Just keep in mind that most games don't use page tables and therefore see no benefit...