JosJuice

What kind of feedback are you seeking on this PR at this stage? Are things working correctly right now?

Have you measured what kind of performance improvement you get from this? Before thinking about making it robust, it would be useful to know how much there is to gain...

At the current stage, the code doesn't look like it will even reliably function, so I don't think that's something we really have to think about at this stage. This...

Did you forget to check in the .cpp file?

There's several problems with the build files: * You didn't remove all the references to {8498F2FA-5CA6-4169-9971-DE5B1FE6132C} from dolphin-emu.sln. * DolphinLib.props hasn't been updated to include the new files. For a...

I would very much like a hwtest. And if we have that, I don't think there's any need to require a unit test on top. Yes, being able to automatically...

Jit64 (but not JitArm64) calls ApproximateReciprocal and ApproximateReciprocalSquareRoot for edge cases, but what's also worth noting is that both JITs read from fres_expected and BaseAndDec. Note that while the unit...

Your CommonFloat.h file is rather similar to Dolphin's Common/FloatUtils.h. I think it would be better to name the file FloatUtils.h, and to follow the approach of Dolphin's Common/FloatUtils.h where relevant...

Sorry for the delay in responding! If we can make the JITs have perfect behavior without making the common path slower, then I think we should do that.

> I'm in favour of this change, however, by just flipping the bool in the code, this will only be applied to fresh Dolphin installs, existing users will have this...