JosJuice
JosJuice
Okay, I suppose we can do one at a time.
The message "Failed to verify patch {} from file {}." currently mentions patches specifically. It should either mention the specific type of code (i.e. Gecko code or patch), or it...
I missed something in my review: The unit test (PatchAllowlistTest.cpp) is still only checking patches, not Gecko codes.
The description of the last commit mentions "a strange compatibility bug with creator name on Gecko codes". Could you explain why this means you should allowlist the SSL patch for...
Also, have you checked what happens if you use netplay code syncing when the person hosting isn't using hardcore mode but the person joining is?
To be explicit about the current review status: What remains is a concept for how netplay code syncing should be handled.
Yes, I'm happy with these comments.
Just one more thing. Could you word wrap the commit message so no line is longer than 72 characters, as per git conventions?
Code looks reasonable, but I have some comments on what we want to apply haptic feedback to. It feels odd to have the "Pause Emulation" button in the in-emulation menu...
By the way, I noticed at least on my phone, the sliders in the settings app don't seem to have haptic feedback. But I normally don't have haptic feedback enabled,...