JosJuice

Results 236 comments of JosJuice

For reference, so that it isn't lost: Here is a log from JMC reproducing the crash. No symbols for the native code, unfortunately. https://pastebin.com/BFpmnxby

We already have our own multithreading when compressing WIA/RVZ, so I don't think we should enable this multithreading option. Sounds fine other than that.

> The type is const std::vector::const_iterator. This can plainly be seen in a debugger. You are not allowed to modify the object from a const_iterator. But there's no reason why...

Regarding the now remaining change: Doesn't this make it so that the "placeholder" header you're creating will override the user's settings?

Ah, so `SaveToDTM` doesn't actually save to a DTM file, it saves to the header you passed in. Yes, that makes sense then.

For the record, I sent a DM to the Arabic translator on July 25th, but haven't received any response yet. Our other two RTL languages, Hebrew and Farsi, are very...

Please ensure that this works under the following situations: * When scoped storage is not active and we ask the user for permission to access storage before running directory initialization....

My remaining comments: * The line in the PR description saying "I'm primarily doing this to make https://github.com/dolphin-emu/dolphin/pull/10725 compatible with our config system" isn't true anymore, right? * The commits...

> My only concern is when there is a problem cheat that causes the game to crash on startup, there is no easy way to disable the cheat. Yes, that...