JosJuice
JosJuice
LGTM if you squash the commits into one.
The commits don't look squashed to me. Did you make sure to push?
Please change the commit title so it matches the PR title. "Correct Removal of Loop [squash]" sounds like the name of one of the squashed commits, not of the larger...
That's still not right. "Correct Removal of Loop" doesn't match what the PR is called or what the change does.
I've checked that this commit generates the expected version codes depending on whether a tag is present. @OatmealDome, please check if the version code scheme makes sense to you.
Oh, I hadn't heard about that. But they still wouldn't allow us to have both versions uploaded and offered to users at the same time, right? That's something we ideally...
The commit we branch out from when making a release isn't necessarily the latest commit. For instance, let's say that we branch out from commit 20010, but the master branch...
You should also support the traversal server (i.e. support specifying a connect code instead of an IP address and port).
Why does Config get to have its tabs "flattened" into the new structure but Graphics doesn't? That feels pretty inconsistent.
The INI files named NG.ini and FP.ini won't be loaded. Dolphin only supports game INIs that have one, three or six of the characters of the game ID.