Jan Holthuis
Is this based on latest main? It will always use the latest commit date of the most recent change of the changelog file. I suppose you need to run `pre-commit...
Hi, thanks for contributing. Unfortunately, there are a bunch of pre-commit issues. Please have a look at the `pre-commit` CI build. There's a patch file you could download to fix...
> Has One an idea how to fix it, or is the failure expected? Yes, it is expected. I didn't have time to fix every qmllint warning.
Btw, I don't think this should be merged. There is no reason to add the linter to the `all` target IMHO.
> I expect the Mixxx.MathUtils issue to be a similar one. That issue is a Qt bug: https://bugreports.qt.io/browse/QTBUG-100326
> So I think it is just the right solution to run qmllint with the build process. This won't work. Only files that are built as qml modules are linted,...
Pre-commit issues: ``` codespell................................................................Failed - hook id: codespell - exit code: 1 res/controllers/Traktor-Kontrol-Z2-hid-scripts.js:829: inbetween ==> between, in between res/controllers/Traktor-Kontrol-Z2-hid-scripts.js:1155: swiched ==> switched eslint...................................................................Failed - hook id: eslint - exit code:...
Please open a thread on Zulip chat. We can help you with git and compiling on Linux. The PR discussion is not the right place for that.
> I notice I will probably not have time to respond to reviews and merge to main before I'm travelling. > Marking as draft again, and finishing it when I'm...
Ok, I think this is ready to review. I'm particulary interested in feedback regard the custom `TableFromListModel` class, which remaps roles from a listmodel into a tablemodel (so that we...