Jan Holthuis
> Shit. I tried to rebase upstream/main because git status was telling that my current branch was commits behind. And it seems I made something weird. :( Yes. Rebase again...
Cna you fix the code style issues? I suggest to use [pre-commit](https://pre-commit.com) locally: $ pre-commit run --from-ref upstream/main --to-ref HEAD
> (doing the PreCommit locally, I haven't figured out as I am currently on a windows machine (to do this with linux, I would need to set up my mini...
> so I tried via git command line resubmitting, then applying patch, but in the end after the patch pre-commit fails without making a second patch If pre-commit finds an...
> pre-commit on git always crashes with: > > ``` > Check Yaml...............................................................Failed > - hook id: check-yaml > - exit code: 1 > > expected a single document in...
Just a suggestion (not blocking merge or something), but if you can't specify full paths anyway, why not just dictate a naming scheme for the sake of shorter command lines?...
> > Why not override the existing mapping? The description [existing mapping also states](https://github.com/mixxxdj/mixxx/blob/f76fe15607909b727ac40bc5067f35e13456b40f/res/controllers/Reloop%20Digital%20Jockey%202%20Controller%20Edition.midi.xml#L5) that the only difference between the "Controller" and "Interface" edition is the built-in sound device. Can...
> > > Does the "Interface Edition" send an additional midi message when the wheel is touched? > > > > > > Yes. In practice this means the CE...
I don't think we have scaling implemented for the other parts of the waveform yet, so I think we should use a fixed size right now. Do we even need...
> > I don't think we have scaling implemented for the other parts of the waveform yet, so I think we should use a fixed size right now. > >...