Jan Holthuis

I recompiled with `DEBUG_ASSERTIONS_FATAL=OFF` to be able to test this. Looks really good! One minor issue I found: The time signature/bpm labels disappear when the left edge of the screen...

Thank you, pre-commit issues have been fixed. Note that you could just have force-pushed to the same branch instead of opening a new PR, but I'll just go ahead and...

I'll convert this to draft until we have a pending manual PR.

Why did you merge main? This makes it impossible to merge into 2.3. Please rebase on 2.3. and remove all commits from main.

> Maybe the simpler for me should be creating a new PR No, this makes no difference because you still need to rebase, but makes review harder because discussion is...

> Analyze/Recordings/Missing Tracks now work as well. > I would not test externalplaylist based features because rythmbox feature crashes here and I don't have any other tools to test. Serato...

Please avoid force-push after review has already started. That makes it harder to see what was changed since last review.

> > if this should be an option > > No options please. I think if we want to support this at all, then options similar to rekordbox are our...

> > can someone also describe what i should fix according to the travis ci build? i dont get it :( > > https://travis-ci.org/github/mixxxdj/mixxx/jobs/735567519 > > These are formatting issues....

> uhm i didnt change anything related to this failed unittest ( i only did changes to the library ) , someone got an idea how to handle this? It's...