Jan Holthuis
Jan Holthuis
Please mark this as ready to review when the review comments have been resolved.
Every time I click on the "Clementine" sidebar entry, I get these warnings: ``` warning [Main] QSqlDatabasePrivate::removeDatabase: connection 'CLEMENTINE_DB_CONNECTION' is still in use, all queries will cease to work. warning...
The Clementine library view itself is still empty, even though I have tracks in my clementine library. When clicking on a Clementine playlist, it crashes with this debug assertion: ```...
> i might have found a indication on the reconnection problem of @Holzhaus, it might be fixed now? Yes, seems to be fixed. > The clementine library view got the...
@julled Hi, can you run `git pull upstream main` and resolve the merge conflicts? The `build/depends.py` file has been removed because we dropped SCons.
> Do you know who could help me with the missing clementine svg for the gui? This should work for now, until someone with better graphics skills finds the time...
> Loading a 8k items library takes about 20 seconds, so i think in a next step one should implement the databaseconnection using a worker thread like other external library...
> So I guess my review doesn't count? Nor does @Holzhaus' review? @ywwg you have a [history](https://github.com/mixxxdj/mixxx/pull/2618#issuecomment-787528962) of belittling others' reviews. It's not okay. Writing "thank you" immediately after pretending...
I left some comments on https://github.com/mixxxdj/manual/pull/390.
https://github.com/katsar0v/mixxx/pull/2