Henry-E

Results 155 comments of Henry-E

There's a lot of old janky stuff with the IDL instructions. The fact that the authority can accidentally passed in the IDL account instead of the buffer here is one...

Uh, I guess since this just fixes an `.md` file it's safe to merge without tests.

Not sure whether this PR is still needed or not?

Recently when doing the VersionedTransaction update I did notice that the Wallet interface doesn't show up in anchor's ts docs. But in general, I don't really understand enough about what's...

This would mean that `anchor test` or `anchor build` would now silently fail when there is no program in the programs directory. This seems like not great behaviour. A better...

i looked into the CLI and there are both `--skip_deploy` and `--skip_build` options you can use.

does anyone else feel like reviewing this?

Best to keep the version changes to a separate PR, assuming I can get it merged quick enough for you

👏 big round of applause for such a massive contribution here. Looks good to merge but as with all things smart contract related should treated extremely carefully. The only major...

This has the thumbs up from armani, which is some indication that it's needed / was missing. The code itself looks good. It checks that the enum has serializable on...