Henry-E
Henry-E
Just testing closing and reopening PR to see if it will ungrey a bunch of the buttons here.
The syntax does seem a bit awkward in terms of needing the program id + the account type name as part of the fetch command.
Briefly looking over the code, it seems odd to add the IDL impl in the `syn` crate and not just add it in the CLI crate. This is partly because...
Maybe it's a dumb call by me but it seems like a use case we can ignore for now and maybe revisit it later. The rust client hasn't had a...
Hard to say. I like the idea of it being pretty printed but in terms of the use case it's for does it make sense to still be pretty printed?...
I think we actually added support for them in a recent PR. https://github.com/coral-xyz/anchor/pull/2260 On Tue, Dec 6, 2022 at 7:10 PM Adithya Narayan ***@***.***> wrote: > Pretty-printed JSON is still...
ah i guess you're right. That PR is all pure ts.
Ok, read through. It looks straightforward enough. One thing though, is there some way to add a test? Maybe the test could piggyback off of one of the existing CLI...
Thanks for all the hard work on this. This PR has definitely made me realise that I need to spend more time looking at the IDL related code. It's surprising...
It's definitely an interesting idea. I will try to confer with armani at some stage about the relative benefits / arguments for using a generated struct for bumps instead of...