anchor icon indicating copy to clipboard operation
anchor copied to clipboard

Fix not being able to import Wallet interface

Open Tristyn opened this issue 2 years ago • 1 comments

This exports Wallet interface, NodeWallet class. Previously the Wallet interface was inaccessible

Also gave workspace a type Record<string, Program>

This is a breaking change. Should I fix tests?

Tristyn avatar May 23 '22 11:05 Tristyn

Please run prettier

yarn run v1.22.18
$ prettier src/** tests/** --check
Checking formatting...
[warn] src/index.ts
[warn] Code style issues found in the above file(s). Forgot to run Prettier?
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 1.

armaniferrante avatar May 26 '22 11:05 armaniferrante

Not sure whether this PR is still needed or not?

Henry-E avatar Dec 06 '22 15:12 Henry-E

I think so but it's nbd. Anchor exports Wallet which is just a clone of NodeWallet, kinda silly

Feel free to close though if you don't want to clean up and merge this

Tristyn avatar Mar 01 '23 08:03 Tristyn

Recently when doing the VersionedTransaction update I did notice that the Wallet interface doesn't show up in anchor's ts docs. But in general, I don't really understand enough about what's happening in this PR to make a judgement call or clean it up

Henry-E avatar Mar 01 '23 12:03 Henry-E

Lets pretend this never happened ;) the-simpsons-homer-simpson

Tristyn avatar Mar 01 '23 20:03 Tristyn