Henry-E

Results 170 comments of Henry-E

Ok added a bunch of tests to verify the behaviour the of the new constraint. - The `destroy` function won't work outside of the constraint usage as the function will...

The only thing left is to maybe rename since the general consensus is that a different name is needed to indicate what constraint does. A high level description - This...

Please use the `close` constraint to close accounts, otherwise you are putting yourself at security risk. Separately: Recommend asking on https://solana.stackexchange.com/ and closing this issue as this is not an...

This would definitely be a nice feature to have!

I'm sure your implementation is fine, I've just been trying to go through but there's quite a lot of code there!

### Under the hood of `Option` This is an informal review of the optional accounts pull request. It adds the ability in Anchor to wrap any generic type `T` that...

Just checking that you have `allow edits from maintainers` active. I wanted to see whether we could include this PR in the next version by testing it localing and pushing...

It looks good as is, I also wondered why `discriminator` wasn't a trait constant. I just wanted to fix the merge conflicts but if you wouldn't mind doing that, that...

Cool, this all sounds good. Do you reckon it's ready for merge now?