Henry-E

Results 162 comments of Henry-E
trafficstars

Closing since we'll merge the other PR. It probably should have had a changelog attached to it.

@armaniferrante is this acceptable behaviour for fetch? It extends the concept of a null account to now also include accounts with 0 data in them. It seems ok because it's...

- Can't get tests to run but it looks fine? - Would like to merge for sure if i can fix the tests thing, otherwise we'll just have to yolo...

It turns out I already merged another PR that makes the whole `fetchNullable` call structure substantially more complex. https://github.com/coral-xyz/anchor/pull/2237 But I still narrowed down where the `data.length` should be checked...

Not if sure @tomlinton or @callensm is best to check this out

Cool, thanks for that. A breaking change doesn't sound great for sure. Might be a close then unfortunately.

Great, @acheroncrypto if you wouldn't mind to fix the merge conflicts when you get a chance and will try merge ASAP!

@acheroncrypto are you happy with merging or any last bits you want to add? Ha, you posted literal seconds before I did. Will merge so

While this does look good there are spaces in the directory names which is not ideal. ..............................⬇️ [spl/src/token-2022 extensions/confidential_transfers.rs](https://github.com/coral-xyz/anchor/pull/2142/files#diff-ce99dd074bfe159d154d8d12cc2ce8e3d8a20eadaaece0a5c0cb4063db98fbee)