Geoffrey Booth
Geoffrey Booth
> Is this just a documentation bug that should be fixed? Yes, the documentation should be using `--import` instead. I posted https://github.com/TypeStrong/ts-node/issues/1909#issuecomment-2089155346 to encourage `ts-node` to update. > I also...
> I don't think the doc annotation adds much in this case The main thing it adds is hinting for the types of arguments in your editor as you work....
> LGTM if lint complaints are fixed. Thanks, that looks like it fixed the lint check, if you don’t mind reapproving.
Can someone please reapprove this so it can land?
> What I mean is that environment variables that affect Node.js, its dependenices, the embedding application, or the embedder’s dependencies must be set before the respective component attempts to use...
> does the feature need fixing? The feature needs fixing. The environment should take precedence over the file.
What I imagined for that TODO was that we support a JSON file as an additional config file that was enabled via a different flag, like `--config=node.config.json`. Node already parses...
I assume that it would probably be trivial to add support for the `node:` prefix to `getBuiltin()`, assuming that fixes this, if you want to spend the time. But yeah,...
> For example, calling `url.protocol` multiple times, will create multiple different strings, rather than the same one. I would think it should be possible to “cache” `protocol` in whatever way...
> url/file-url-to-path.js n=100000 url=’(url) file:///home/user/test/index.js’ *** -95.88 % ±3.25% ±4.44% ±6.03% This seems to show that in the most common case of a `file://` URL, this is 96% slower?