Geoffrey Booth comments

Results 538 comments of


                                            Geoffrey Booth

Tracking issue: require(esm)

@nodejs/loaders

src: rewrite task runner in c++

This should’ve had the @nodejs/test_runner team tagged. I assume this change is fine, and desirable, but I’d like to hear from them what it might mean for future development of...

src: rewrite task runner in c++

> this is about the task runner, not the test runner Sorry, my mistake!

src: rewrite task runner in c++

For `node --run`, I kind of feel like it's important to support `--env-file`? It's a common use case to define environment variables for running scripts or starting servers.

src: rewrite task runner in c++

> Maybe we should rename it script runner if this keeps getting happening 😅 Yeah or just refer to it as `node --run`.

Provide some mechanism to conditionally and synchronously import modules (or just builtins) from ESM

@nodejs/loaders

lib,src: remove --experimental-policy

> I’m adding the `dont-land` labels as requested by @richardlau to follow the deprecation cycle. So, here’s the plan: I thought we never deprecated experimental features? Ideally we would land...

lib,src: remove --experimental-policy

I think it's less disruptive to remove this as part of 22.0.0 than later in the 22 line, or in 23.

src: add support to override local env variables option

> Is there a specific process I should follow before creating a PR? There isn’t, but generally I encourage people to open an issue proposing a new feature before going...

src: add support to override local env variables option

> disagree that we shouldn’t block on docs being inconsistent but I don’t think this is the venue to hash that out I don’t think it’s a blocking concern for...