Geoffrey Booth
Geoffrey Booth
> Somewhat related: with #52219 it should be possible to just implement this in the user land. I think this should already be possible with the module hooks that we...
Just to be clear, I assume you’re proposing flagging `assert` syntax but _not_ `with` syntax, correct? We shouldn’t be flagging the latter. I don’t see much point in flagging something...
I vote for removing `assert` in 22 and adding a warning for all previous lines. What do others think? And `with` would be unflagged.
> @MoLow @anonrig Do you think it would be good to fix these tests or should I focus on my code? What are the test failures, for at least a...
1. Probably not; go for it. 2-3. I would actually start at `esm/translators.js`. That’s the file that’s common to both flows, though the CommonJS flow uses the CommonJS “translator” function...
> Hey just wondering, are the failing tests actually related to changes introduced in this PR? Probably not, especially if they happen only on certain platforms. We generally click “resume”...
First, we’ve been discouraging use of `NODE_ENV` for many years now. I don’t see us shipping a solution that relies on that. It’s not one of the [supported environment variables](https://nodejs.org/api/cli.html#environment-variables)....
> Is it possible to add some options, specifically to the programmatic API, to quietly handle missing files ? This could be useful for other things down the line too...