Geoffrey Booth

Results 623 comments of Geoffrey Booth

> IMHO, the fact that archives (tar) or members of archives (zip) are commonly compressed does not mean that supporting compression is any justification for supporting archives. I think the...

> I think the simplest way to solve this would be to use the hint if present. If the hint is not present, use some default. To be more powerful/flexible,...

> How many cases in the current module mocking tests begin to fail with the changes in https://github.com/nodejs/node/pull/53619? In `./node --experimental-test-module-mocks --experimental-require-module ./test/parallel/test-runner-module-mocking.js` the following fail: - CJS mocking with...

Actually I might’ve been mistaken about one part: does the URL of the module to be mocked need to exist? Because if we only support mocking modules that exist, we...

> Regarding the module mocking . . . I think there are a few options to fix it: I think the mocking thing might need a change to the mocking...

Update: I figured out the `require.resolve` test. The `load` hook had an `if (result.format === 'commonjs')` condition that needed updating to allow for an undefined `format`. Now all that remains...

With https://github.com/nodejs/node/pull/53642 landed, now all the tests pass. This is ready for review. Assuming we think this is ready to land, the other question we need to answer is how...

> If we do decide this can be backported, instead of making the flag a noop, maybe swap the default so it defaults to being enabled but can still be...

I’ve updated the docs. What are we thinking re backporting and flags? 1. Unflag it in 23.0.0, wait a bit to see if anyone complains, then backport the unflagging. 2....

Per discussion in https://github.com/nodejs/TSC/issues/1592, adding this to the agenda to be discussed more in the next TSC meeting. I think we have a tentative consensus to: - Keep the `--experimental-detect-module`...