node
node copied to clipboard
Published
20 hours ago •
nodejs
nodejs
typings: lib/internal/vm.js
@GeoffreyBooth thanks so much for opening a PR! To be honest, I don't think the doc annotation adds much in this case given they're just a long form of the variable/function names. Would it be OK if we close this without merging it? Thanks for understanding.
I don't think the doc annotation adds much in this case
The main thing it adds is hinting for the types of arguments in your editor as you work. This was waiting on another PR from @joyeecheung but it might be unblocked now. I'm not sure when I'll have time to rebase but anyone else can finish this.
LGTM if lint complaints are fixed.
Thanks, that looks like it fixed the lint check, if you don’t mind reapproving.
I don't think the doc annotation adds much in this case
The main thing it adds is hinting for the types of arguments in your editor as you work. This was waiting on another PR from @joyeecheung but it might be unblocked now. I'm not sure when I'll have time to rebase but anyone else can finish this.
Gotcha! Thanks for following up. LGTM.
Commit Queue failed
- Loading data for nodejs/node/pull/50112 ✔ Done loading data for nodejs/node/pull/50112 ----------------------------------- PR info ------------------------------------ Title typings: lib/internal/vm.js (#50112) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch GeoffreyBooth:type-internal-compile-function -> nodejs:main Labels vm, author ready, typings, commit-queue-squash Commits 7 - typings: lib/internal/vm.js - @legendecas suggestion - lint - Apply suggestions from code review - Update lib/internal/vm.js - Apply suggestions from code review - Apply suggestions from code review Committers 2 - Geoffrey Boothhttps://github.com/nodejs/node/actions/runs/7815976165- GitHub PR-URL: https://github.com/nodejs/node/pull/50112 Reviewed-By: Yagiz Nizipli Reviewed-By: Chengzhong Wu Reviewed-By: Franziska Hinkelmann Reviewed-By: Joyee Cheung ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50112 Reviewed-By: Yagiz Nizipli Reviewed-By: Chengzhong Wu Reviewed-By: Franziska Hinkelmann Reviewed-By: Joyee Cheung -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 10 Oct 2023 03:48:21 GMT ✔ Approvals: 4 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/50112#pullrequestreview-1861179506 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/50112#pullrequestreview-1864665265 ✔ - Franziska Hinkelmann (@fhinkel): https://github.com/nodejs/node/pull/50112#pullrequestreview-1864005359 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/50112#pullrequestreview-1865292289 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
Commit Queue failed
- Loading data for nodejs/node/pull/50112 ✔ Done loading data for nodejs/node/pull/50112 ----------------------------------- PR info ------------------------------------ Title typings: lib/internal/vm.js (#50112) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch GeoffreyBooth:type-internal-compile-function -> nodejs:main Labels vm, author ready, typings, commit-queue-squash Commits 3 - typings: lib/internal/vm.js - @legendecas suggestion - lint Committers 1 - Geoffrey Boothhttps://github.com/nodejs/node/actions/runs/7949622474PR-URL: https://github.com/nodejs/node/pull/50112 Reviewed-By: Yagiz Nizipli Reviewed-By: Chengzhong Wu Reviewed-By: Franziska Hinkelmann Reviewed-By: Joyee Cheung ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50112 Reviewed-By: Yagiz Nizipli Reviewed-By: Chengzhong Wu Reviewed-By: Franziska Hinkelmann Reviewed-By: Joyee Cheung -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - typings: lib/internal/vm.js ⚠ - @legendecas suggestion ⚠ - lint ℹ This PR was created on Tue, 10 Oct 2023 03:48:21 GMT ✔ Approvals: 4 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/50112#pullrequestreview-1861179506 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/50112#pullrequestreview-1864665265 ✔ - Franziska Hinkelmann (@fhinkel): https://github.com/nodejs/node/pull/50112#pullrequestreview-1864005359 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/50112#pullrequestreview-1865292289 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-02-17T23:55:37Z: https://ci.nodejs.org/job/node-test-pull-request/57165/ - Querying data for job/node-test-pull-request/57165/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu