node icon indicating copy to clipboard operation
node copied to clipboard

test: migrate messages v8 tests from Python to JS

Open ognjenjevremovic opened this issue 1 year ago β€’ 2 comments

Migrated messages v8 tests from Python to JavaScript. This change is part of an effort to enhance maintainability and consistency in the test suite. All relevant test files and dependencies have been updated accordingly.

Refs: https://github.com/nodejs/node/issues/47707

Summary

This pull request addresses Issue #47707, which involved migrating messages v8 tests from Python to JavaScript to enhance maintainability and consistency in the test suite.

Changes Made

  • Migrated messages v8 tests from Python to JavaScript.
  • Updated all relevant test files and snapshots accordingly.

Additional Notes

  • The changes adhere to the Node.js testing and coding style guidelines.
  • Automated tests for the migrated messages v8 tests have passed successfully.

Tests affected:

- errors/assert_throws_stack.js
- errors/console_assert.js
- errors/eval_messages.js
- errors/internal_assert.js
- errors/internal_assert_fail.js

Related Issues

Improves: Issue #47707

Checklist

  • [x] Test changes have been linted and pass the automated tests.
  • [x] Code follows the Node.js testing and coding style guide.
  • [x] Commits are atomic and convey meaningful changes.
  • [x] Pull request is based on the latest main branch.

ognjenjevremovic avatar Jan 20 '24 12:01 ognjenjevremovic

CI: https://ci.nodejs.org/job/node-test-pull-request/56930/

nodejs-github-bot avatar Jan 26 '24 21:01 nodejs-github-bot

Hey just wondering, are the failing tests actually related to changes introduced in this PR?
Is there any additional steps (or fixes) I should provide regarding this PR?

ognjenjevremovic avatar Feb 07 '24 20:02 ognjenjevremovic

Hey just wondering, are the failing tests actually related to changes introduced in this PR?

Probably not, especially if they happen only on certain platforms. We generally click β€œresume” a few times to rerun CI because many tests are flaky.

Sorry for not getting to this sooner! Thank you for the contribution!

GeoffreyBooth avatar Mar 23 '24 00:03 GeoffreyBooth