node
node copied to clipboard
nodejs
lib,src: remove --experimental-policy
Refs: https://github.com/nodejs/node/issues/52575
Summary: We are dropping the --experimental-policy feature from Node.js.
Review requested:
- [ ] @nodejs/loaders
- [ ] @nodejs/security-wg
- [ ] @nodejs/startup
Generally in favor of this PR, we should probably warn people against using it in the meantime in a smaller semver-ptch PR
We should doc deprecate it immediately -- even if it's not a requirement for experimental features to go through a full deprecation cycle the earlier we inform users that the feature is going away the better.
This is now ready to review. I'm adding the dont-land labels as requested by @richardlau to follow the deprecation cycle. So, here's the plan:
- I'll open a new PR to update the doc to doc-deprecated
- Merge that PR
- Land doc-deprecation in all release lines
- Merge this PR
- Land this PR in all release lines
I’m adding the
dont-landlabels as requested by @richardlau to follow the deprecation cycle. So, here’s the plan:
I thought we never deprecated experimental features?
Ideally we would land this as part of 22.0.0.
I’m adding the
dont-landlabels as requested by @richardlau to follow the deprecation cycle. So, here’s the plan:I thought we never deprecated experimental features?
Ideally we would land this as part of 22.0.0.
We have in the past: https://github.com/nodejs/node/pull/12243 I don't believe it is a requirement for experimental features to go through a full deprecation cycle, but that doesn't stop us doc-deprecating things. For example, I'd be much more hesitant to backport this PR (with 89 touched files) to LTS immediately -- I'd probably want to wait longer than the usual "two weeks in current" policy just due to the number of files touched whereas I'd have no issue with landing doc deprecations in line with the two week policy.
I think it's less disruptive to remove this as part of 22.0.0 than later in the 22 line, or in 23.
This is more of a meta note, but if we remove the experimental policy, we should also remove the issue label (policy) as well.
Can we fast-track a doc-deprecation in 22? Maybe changing the experimental warning into deprecation warning too if that's not too much hassle? Then we can proceed with this PR for later versions of 22, or 23.
EDIT: oh I see https://github.com/nodejs/node/pull/52602 now
doc-deprecation has been merged. I will wait for it to land on v22/v21 then I will proceed with this PR as it will hard conflict if I just merge it with dont-land-*.
Failed to start CI
⚠ Something was pushed to the Pull Request branch since the last approving review. ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/8883463760
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
The https://github.com/nodejs/node/labels/notable-change label has been added by @RafaelGSS.
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.
Failed to start CI
⚠ Something was pushed to the Pull Request branch since the last approving review. ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/8884508901
Failed to start CI
⚠ Something was pushed to the Pull Request branch since the last approving review. ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/8886863709
Failed to start CI
⚠ Something was pushed to the Pull Request branch since the last approving review. ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/8976580157
