Jason Frey

Results 678 comments of Jason Frey

Should these new methods be private methods?

I'm surprised this PR is still mergeable - would like @agrare to review and then either accept or close.

This is actually really cool - surprised I hadn't seen this PR before.

@jrafanie I'm thinking we should make this part of the worker itself. Perhaps even dumping the output in the same place we dump Ruby GC output? https://github.com/ManageIQ/manageiq/blob/518eaff3c0aacdb9f467eef6d791069feed9fbc7/app/models/miq_worker/runner.rb#L281 I'm thinking we...

Reopening cause I thikn we still need this.

Do we need a schema migration for this as well, or is deletion of the event handled at seeding time?

@jeffibm would it be possible for you to come up with a rough estimate for how much effort this would be? If we can get away with updates for security...

This one fell to the backburner, but I originally had concerns/thoughts around how to handle providers that don't support this column, and thus the value would be nil, and what...

Can you explain why we need the `id` changes? There are a gazillion of them. Are the relationships lost or something in the cached stubs?

@MelsHyrule Can you please take a look at this one?