Remove default from config_scripts payload_valid
Only set payload_valid if it was checked otherwise leave it as nil
https://github.com/ManageIQ/manageiq-providers-workflows/pull/59#issuecomment-1810299583
db/migrate/20231114173829_remove_default_from_configuration_scripts_payload_valid.rb
- [ ] :exclamation: - Line 3, Col 5 - Style/MethodCallWithArgsParentheses - Use parentheses for method calls with arguments.
- [ ] :exclamation: - Line 7, Col 5 - Style/MethodCallWithArgsParentheses - Use parentheses for method calls with arguments.
ping @Fryguy
This pull request has been automatically marked as stale because it has not been updated for at least 3 months.
If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).
ping. Is this ready?
@Fryguy Is there a timeframe that is best to merge these schema PRs?
This one fell to the backburner, but I originally had concerns/thoughts around how to handle providers that don't support this column, and thus the value would be nil, and what that means (i.e. since nil is falsey, are they therefore invalid by default?)
This pull request has been automatically marked as stale because it has not been updated for at least 3 months.
If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).
@Fryguy how about we rename this payload_invalid so that the "unset" case isn't that the content is bad.