manageiq-schema icon indicating copy to clipboard operation
manageiq-schema copied to clipboard

Remove default from config_scripts payload_valid

Open agrare opened this issue 2 years ago • 10 comments

Only set payload_valid if it was checked otherwise leave it as nil

https://github.com/ManageIQ/manageiq-providers-workflows/pull/59#issuecomment-1810299583

agrare avatar Nov 14 '23 17:11 agrare

Checked commit https://github.com/agrare/manageiq-schema/commit/36c0807f37ce8ec5be6768de28efbc3f07a9f7b9 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint 1 file checked, 2 offenses detected

db/migrate/20231114173829_remove_default_from_configuration_scripts_payload_valid.rb

miq-bot avatar Nov 14 '23 18:11 miq-bot

ping @Fryguy

agrare avatar Dec 04 '23 17:12 agrare

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

miq-bot avatar Mar 11 '24 00:03 miq-bot

ping. Is this ready?

kbrock avatar Mar 11 '24 14:03 kbrock

@Fryguy Is there a timeframe that is best to merge these schema PRs?

kbrock avatar Apr 05 '24 17:04 kbrock

This one fell to the backburner, but I originally had concerns/thoughts around how to handle providers that don't support this column, and thus the value would be nil, and what that means (i.e. since nil is falsey, are they therefore invalid by default?)

Fryguy avatar Apr 05 '24 18:04 Fryguy

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

miq-bot avatar Jul 08 '24 00:07 miq-bot

@Fryguy how about we rename this payload_invalid so that the "unset" case isn't that the content is bad.

agrare avatar Sep 04 '24 20:09 agrare