Refactor MiqProvisionWorkflow#initialize method and subclasses

[chessbyte]

[Fryguy]

Should these new methods be private methods?

[chessbyte]

@lfu when you get a chance, if you can review and validate in a real provision workflow (I don't have environment to try it), that would be great. This is NOT URGENT and very low priority.

[chessbyte]

@lfu I re-ordered the initialize method here because it seemed that the dialog initialization and configuration has nothing to do with the password_helper and setting instance variables. Let me know if my assumptions are wrong.

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

[kbrock]

This removes a bunch of copy paste code.

Do we want to pick this up, or let stale make it disappear?

[Fryguy]

I'm surprised this PR is still mergeable - would like @agrare to review and then either accept or close.

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

[miq-bot]

Checked commits https://github.com/chessbyte/manageiq/compare/55f03f01c6bec33f413a1536ee9f54da39c7218e~...c7243c99ad4d3d322d15951034e34a83184c3054 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 3 files checked, 5 offenses detected

app/models/miq_provision_virt_workflow.rb

• [ ] :warning: - Line 1117, Col 3 - Lint/IneffectiveAccessModifier - private (on line 965) does not make singleton methods private. Use private_class_method or private inside a class << self block instead.

app/models/miq_request_workflow.rb

• [ ] :warning: - Line 1524, Col 26 - Lint/UnusedMethodArgument - Unused method argument - values. If it's necessary, use _ or _values as an argument name to indicate that it won't be used. If it's unnecessary, remove it.
• [ ] :warning: - Line 1535, Col 25 - Lint/UnusedMethodArgument - Unused method argument - values. If it's necessary, use _ or _values as an argument name to indicate that it won't be used. If it's unnecessary, remove it. You can also write as configure_dialogs(*) if you want the method to accept any arguments but don't care about them.
• [ ] :warning: - Line 1535, Col 33 - Lint/UnusedMethodArgument - Unused method argument - options. If it's necessary, use _ or _options as an argument name to indicate that it won't be used. If it's unnecessary, remove it. You can also write as configure_dialogs(*) if you want the method to accept any arguments but don't care about them.
• [ ] :exclamation: - Line 1530, Col 34 - Style/IfInsideElse - Convert if nested inside else to elsif.

[kbrock]

update:

• rebased to fix conflict

Can fix cops if we deem we want to still work on this

@Fryguy @agrare do we still want this, or just close?