Jason Frey

Results 678 comments of Jason Frey

I think maybe remove the surrounding `"` - they are redundant and only seem to add noise? Another options might be to just now show the string at all, and...

If this continues to fail, you probably just need to delete the CI cache - the cache is likely pointing to an older version of the other repos...this is not...

I killed the cached, so I'm rekicking this.

I think the reason this is failing is because the .pot/.po files needs to be rebuilt as part of this PR (or separately on master and merged). The test is...

I'm curious why this depends on https://github.com/ManageIQ/manageiq/pull/23608. We're not actually making Vm and MiqTemplate abstract here.

I see, so queries to the base VmOrTemplate fail?

Reminder that we have a po to json patch in our patches (you don't think we ever upstreamed it but we should). Can you verify that patch still is correct?...

> you don't think we ever upstreamed it but we should Reading back I don't know why I wrote "you" I meant "I"

@bdunne We can't merge this because of https://github.com/ManageIQ/manageiq/pull/23056. Is there a way we can add a test for that? I know it's during build but I don't understand what causes...

> db:migrate loads from schema by default for fresh databases (may need the old behavior if undesirable) I would actually love this. In the past we couldn't do it because...