Jason Frey

Results 678 comments of Jason Frey

Reopening to make sure it gets rescanned

cc @agrare moreso on the processing side of this column. > This patch adds the columns to be cache store for those values, and should be triggered on every update...

My thoughts were here and are the same https://github.com/ManageIQ/manageiq-schema/pull/322#issuecomment-561756398

FWIW, I think this should be done at model save time (calculate during record save and update if necessary) and I'm ok with caching these as columns, but really want...

@miq-bot cross-repo-test manageiq-ui-classic, manageiq-api, manageiq-content, manageiq-automation_engine

cross-repo failed on the automation engine - not sure if related or not

Backported to `radjabov` in commit 719adb594a30b71be77f367a7b7017c44c649e3d. ```text commit 719adb594a30b71be77f367a7b7017c44c649e3d Author: Jason Frey Date: Fri May 24 16:29:58 2024 -0400 Merge pull request #23037 from agrare/add_generic_mailer_deliver! Add a `deliver!` version of...

It was brought up by `@fxn` early on in https://bugs.ruby-lang.org/issues/18273 and even in the docs discussion https://github.com/ruby/ruby/pull/5480, but it seemed to not be important enough to have `.subclasses` be accurate,...

I'm curious what @fxn thinks here. I was avoiding pinging him, but in my case zeitwerk is involved here, and stub_const + zeitwerk + remove_const not working as expected is...

@byroot that's a great point that the code must have a strong reference to the original constant in order to restore it. I'm not sure how we get around that...