Dimitri Papadopoulos Orfanos
Dimitri Papadopoulos Orfanos
It seems ready to merge as far as I'm concerned.
Add `PT031` to the list of rules of ignore (for now): https://github.com/zarr-developers/numcodecs/blob/4fdb62507376c3896dfb25a02ca36cb4cdd6e913/pyproject.toml#L201-L204
Requires #791 to pass tests: ```diff - ruff-pre-commit - rev: v0.11.12 - hooks: - - id: ruff + ruff-pre-commit + rev: v0.13.3 + hooks: + - id: ruff-check ```
Same here. Would you accept help to move to a more current build system?
Options for the build backend include: * [setuptools](https://github.com/pypa/setuptools), like [pytest](https://github.com/pytest-dev/pytest/) or [pluggy](https://github.com/pytest-dev/pluggy), pretty standard but complex because of the burden of compatibility with old projects * [flit](https://github.com/pypa/flit), simpler for pure...
PEP 639 support requires [**`flit_core >=3.11`**](https://flit.pypa.io/en/stable/history.html#version-3-11). https://github.com/pypa/pyproject-hooks/blob/10093cd5bc488c6ffbb4dfa034f54c7ac1e3178e/pyproject.toml#L2
How to reproduce this warning? I tried with the attached `sample_rate.py` without success. https://gist.github.com/DimitriPapadopoulos/599ccc16b294d22e833e566176ed3caf
So that would be [`test_read_shhs`](https://github.com/cbrnr/sleepecg/blob/dc6fb62fbee89312b1c4b5d682b69ae3f667d800/sleepecg/test/test_sleep_readers.py#L153-L165), which [calls `read_shhs`](https://github.com/cbrnr/sleepecg/blob/dc6fb62fbee89312b1c4b5d682b69ae3f667d800/sleepecg/test/test_sleep_readers.py#L159): ```py def test_read_shhs(tmp_path): """Basic sanity checks for records read via read_shhs.""" durations = [0.1, 0.2] # hours valid_stages = {int(s) for s...
Could it depend on the version of pyedflib, with a different version used in either cases?
Perhaps the problem is here is in [make_signal_header](https://github.com/holgern/pyedflib/blob/b7e4c34c8592be19de0374852c481f09e2446b20/pyedflib/highlevel.py#L204-L253): ```python signal_header = {'label': label, 'dimension': dimension, 'sample_rate': sample_rate, 'sample_frequency': sample_frequency, 'physical_min': physical_min, 'physical_max': physical_max, 'digital_min': digital_min, 'digital_max': digital_max, 'transducer': transducer, 'prefilter':...