Dimitri Papadopoulos Orfanos

Results 835 comments of Dimitri Papadopoulos Orfanos

I can remove the last commit: https://github.com/pypa/hatch/pull/1890/commits/8d75a8e046c07600186ab6b7c32c326bb650f604. CI will fail until quoting is fixed: https://github.com/pypa/hatch/blob/136c763a2a348eab0ab214c2c0f1895dc721c9c9/ruff.toml#L8

Done. 1. Modify `ruff.toml`. 2. Run `ruff format`. Changes are a little bit massive, not easy to review. You might want to rerun locally to make sure my last commit...

Most linter rules don't dramatically improve individual pieces of code as such. Yet, you have already enabled some rules. Why? Like the rules you have already enabled, these new rules...

The PR is made of small commits, each one applying a rule. The explanation for each rule is available in the Ruff [Rules](https://docs.astral.sh/ruff/rules/#rules) documentation. Copying the rationale for each rule...

I don't get it. While you're not a fan of enforcement, you already use a formatter and a linter, which don't leave much choice. I'm adding some rules that I...

I can try to split into multiple PR's. It would be easier to: - review the changes, - evaluate the usefulness of each ruleset.

Indeed, I have _applied some_ SIM rules, but do _not enforce_ them. My experience so far is that many of these SIM rules modify the existing code too much, without...

I believe the justification for most of the rules is in the rules themselves, but I clearly need to explain better. Let me repeat what I've written in the PR...

* Support for free threaded Python requires CFFI [v2.0.0](https://cffi.readthedocs.io/en/stable/whatsnew.html#v2-0-0). * CFFI [v2.0.0](https://cffi.readthedocs.io/en/stable/whatsnew.html#v2-0-0) does not support CPython 3.13t, only CPython 3.14t. > Added support for free threaded CPython (3.14t+ only). ([#178](https://github.com/python-cffi/cffi/pull/178))...