Dimitri Papadopoulos Orfanos
Dimitri Papadopoulos Orfanos
Superseded by #3214.
I suggest you remove this: https://github.com/pypa/wheel/blob/1e00742acc9fb33f6e71460c3844c2b66532af7f/pyproject.toml#L71-L74 It had been forgotten when shifting from black to ruff in https://github.com/pypa/wheel/commit/83b77e591e6f593470f8daddf3bcfd6ca64e81bc.
Nope. it's not redundant. It's set for pre-commit, but not for standalone ruff runs.
Because I simply run ruff.
Yet, I do have `ruff` installed. When I run ruff, results are not consistent with pre-commit.
Of course. It's just that pre-commit skips vendored, while standalone ruff does not.
I tend to avoid pre-commit, it doesn't work well outside containers and virtualenvs on older Linux distributions, typically the oldest still maintained Ubuntu LTS.
> Note that we use `xfail` in various places to prevent the CI from failing due to downloading issues Any suggestion how to identify such tests?
* I would recommend keeping [B004](https://docs.astral.sh/ruff/rules/unreliable-callable-check/), it does result in more correct code, although this should seldom be an issue in practice: > Using `hasattr` is an unreliable mechanism for...
> Other changes do not look like they improve the code in a meaningful way (B007, B004, B010); we can stil implement the changes, however. I have kept the changes...