Dimitri Papadopoulos Orfanos

Additionally, I have discovered that the documentation of [`pyedflib.highlevel.make_signal_header`](https://pyedflib.readthedocs.io/en/latest/ref/highlevel.html#pyedflib.highlevel.make_signal_header) and [`pyedflib.highlevel.make_signal_headers`](https://pyedflib.readthedocs.io/en/latest/ref/highlevel.html#pyedflib.highlevel.make_signal_headers) claims that "_The default is 256_" for `sample_rate`, instead I feel it should be `None`, and that the "_The...

> > Perhaps the problem is here is in [make_signal_header](https://github.com/holgern/pyedflib/blob/b7e4c34c8592be19de0374852c481f09e2446b20/pyedflib/highlevel.py#L204-L253): > > I tried popping that dict key before writing the EDF, this didn't have any effect on the warning....

Could you give #231 a try?

@cbrnr I have installed [`sleepecg`](https://github.com/cbrnr/sleepecg) in dev mode. Should I see the warning when running `pytest`?

Branch [:make_signal_header](https://github.com/DimitriPapadopoulos/pyedflib/tree/make_signal_header) does work for me. Commits 35e5ed773dd8f0542dafcdece288ebcd78b860d3 and 5aebc8e410a24c2a08d24df010185b6d73656900 are sufficient to fix this particular warning.

As for why you see the warning with `pytest` only: 1. `DeprecationWarning` is [ignored by default](https://docs.python.org/3/library/exceptions.html#DeprecationWarning): > _exception_ **DeprecationWarning** > > Base class for warnings about deprecated features when those...

With `pytest`: * I see the warning when on the [_master_](https://github.com/DimitriPapadopoulos/pyedflib/tree/master) branch of my pyedflib: pytest with pyedf master branch ``` $ pytest-3 ======================================================= test session starts ======================================================== platform linux...

We will first need to decide how we want to handle `sample_rate`. In any case, we should probably avoid warnings when **reading** `sample_rate` except when the value is inconsistent with...

Indeed, the warning should be emitted when **writing** and **explicitly passing** `sample_rate` as an argument. It should not be emitted when reading, unless of course `sample_rate` and `sample_frequency` are different....

Do you have in mind the changes from `str + str` to `f"{str}{str}"`? Not sure about them either. While f-strings are faster and considered more readable in a majority of...