Dimitri Papadopoulos Orfanos

Results 829 comments of Dimitri Papadopoulos Orfanos

Rebased to resolve conflicts and fixed tests in #386.

This PR looks in good shape. @adrienverge When you have time, I think it would be worth reviewing and eventually merging it.

> ``` > yamllint auto-detects when it's running inside of a GitLab CI/CD job > and automatically uses the suited output format to get the > results as a `Code...

LGTM, and an addition worth the additional complexity as far as I'm concerned. But the this is up to the maintainer and I know he's quite busy. Please be patient.

Unliek the previous version, the new version of [pypa/cibuildwheel](https://github.com/pypa/cibuildwheel) attempts to build free threading wheels, and fails. We do need to fix that failure, but for now disable free threading....

It looks like the `pkg-config` executable is expected and missing on Windows. Not sure how this wasn't the case before...

After bumping cibuildwheel, CMake cannot find the `pkg-config` executable on Windows: ``` CMake Error at C:/Program Files/CMake/share/cmake-4.1/Modules/FindPackageHandleStandardArgs.cmake:227 (message): Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE) Call Stack (most recent call first):...

I understand that the `pkg-config` executable itself is missing. I can see that `PKG_CONFIG_PATH` is defined and points to the location of Python `.pc` files (`C:\hostedtoolcache\windows\Python\3.12.10\x64/lib/pkgconfig`) but that environment variable...

Tried your suggestion. I don't know enough about this part of the build process to be useful.

I don't know enough about scikit-build-core or CMake to find where to add the above code. It might be easier to fix `pkg-config` :smile: Where is `pkg-config` downloaded from? conda-forge?...