Dimitri Papadopoulos Orfanos

Results 829 comments of Dimitri Papadopoulos Orfanos

Still need to fix this new error in a test: ``` FAILED skrub/tests/test_multi_agg_joiner.py::test_default_cols[pandas-nullable-dtypes] - AssertionError: assert [['rating', '...', 'movieId']] == [['rating', '...ng', 'genre']] At index 1 diff: ['rating', 'genre', 'movieId']...

Note that Ruff can automatically apply some rules, and pre-commit will enforce that without any additional work from contributors. Therefore, rules with automatic fixes are not a barrier, they result...

Note that pre-commit will format and apply a large part of the Ruff rules automatically, without requiring any action from contributors.

Is pre-commit more a security risk than GitHub actions, AI agents, and GitHub itself? It's a genuine question, I'm not sure how pre-commit is worse than GitHub, and couldn't find...

Restarted from scratch, it's easier and less error-prone than rebasing.

Bugfix is in progress: https://github.com/pypa/setuptools-scm/issues/1180#issuecomment-3150183900 I guess this not a hatch issue. setuptools_scm v9.0.0 should be avoided - chances are it will be yanked once v9.0.1 is out.

I have rebased onto `main`. Should I rebase onto `merge-staging`?

Upgrading [zlib-ng](https://github.com/zlib-ng/zlib-ng) from [2.0.7](https://github.com/zlib-ng/zlib-ng/releases/tag/2.0.7) to [2.1.8](https://github.com/zlib-ng/zlib-ng/releases/tag/2.1.8) breaks the build. https://github.com/zlib-ng/zlib-ng/compare/2.0.7...2.1.8 I need to look into it...

Upgrading [zlib-ng](https://github.com/zlib-ng/zlib-ng) from [2.0.7](https://github.com/zlib-ng/zlib-ng/releases/tag/2.0.7) to [2.1.0-beta1](https://github.com/zlib-ng/zlib-ng/releases/tag/2.1.0-beta1) breaks the build as well https://github.com/zlib-ng/zlib-ng/compare/2.0.7...2.1.0-beta1

The CI error is: ``` ImportError: Error importing plugin "pytest_dependency": No module named 'pytest_dependency' ``` It's as if `pytest_dependecy` was not installed when running tests. Will have to look into...