setuptools icon indicating copy to clipboard operation
setuptools copied to clipboard

Enforce ruff/pyupgrade rules (UP)

Open DimitriPapadopoulos opened this issue 1 year ago • 3 comments

Summary of changes

Enforce ruff/pyupgrade rules (UP).

Follow-up of #4125.

Pull Request Checklist

DimitriPapadopoulos avatar May 22 '24 12:05 DimitriPapadopoulos

You should ignore UP038 too ! https://github.com/astral-sh/ruff/issues/7871

Avasam avatar May 22 '24 15:05 Avasam

Restarted from scratch, it's easier and less error-prone than rebasing.

DimitriPapadopoulos avatar Sep 10 '24 10:09 DimitriPapadopoulos

Might wanna disable UP027 too (I've done so here: https://github.com/pypa/setuptools/pull/4558)

Avasam avatar Sep 18 '24 23:09 Avasam

CI failure looks completely unrelated, I got the same thing here: https://github.com/pypa/setuptools/actions/runs/11113018762/job/30876386043?pr=4556

Avasam avatar Sep 30 '24 19:09 Avasam

@jaraco and/or @abravalheri Can this be reviewed? Finishing to enable all UP rules is a PR I would've done as well if this one didn't already exists.

Avasam avatar Dec 31 '24 16:12 Avasam

Looks great. Thanks!

jaraco avatar Dec 31 '24 18:12 jaraco