Dimitri Papadopoulos Orfanos

Results 835 comments of Dimitri Papadopoulos Orfanos

For what it's worth, I tried `ruff format` with different values of [`quote-style`](https://docs.astral.sh/ruff/settings/#format_quote-style): * **`double`** 93 files changed, 5311 insertions(+), 4030 deletions(-) git diff --stat ```console $ git diff --stat...

See #1513 for formatting with `ruff format` instead of `black`.

I just tried to apply some rules that raised a few valid issues in other projects.

The "reason" is: > authentik-radius outpos has shared secret 128 characters in length The max length is probably buried somewhere in https://github.com/goauthentik/authentik/tree/main/authentik/providers/radius or even higher up under https://github.com/goauthentik/authentik/tree/main.

It's hard to infer from the source code. I'll ask the end-user...

When authenticating using `radtest` from freeradius, with _1234_ as the password, the authentik radius server sends this JSON message internally: ``` [Path with value: /password:1234] [Member with value: password:1234] String...

Thank you so much for the links. They are not crystal clear to me either, but [RFC2865](https://datatracker.ietf.org/doc/html/rfc2865#section-5.2) does say: > The String field is between 16 and 128 octets long,...

However, I am not an expert of Radius, and still fail to understand how the following relate and interact: * `User-Password` which is between 16 and 128 octets long, *...

The shared secret should be at least 16 octets: > The secret (password shared between the client and the RADIUS server) SHOULD be at least as large and unguessable as...

Yes, it took me some time, but I eventually sorted it out :smile: