Boshen

Results 565 comments of Boshen

A quick research among native languages: * esbuild and boa uses `[u16]` * swc doesn't handle surrogates, ast explorer shows `"\\udf06"` and `"\\\u0000udf06"` If we are implementing a runtime, I'd...

Yes, from Mathias: https://mathiasbynens.be/notes/javascript-identifiers-es6

The code here is wrong https://github.com/oxc-project/oxc/blob/4757376136441ffd2ceb6bed97b94e6351b94b22/crates/oxc_parser/src/lexer/unicode.rs#L126-L143 We need mark the string as "broken" in the `char::try_from(code_point)` error branch.

In #9918, I made the following changes: In `StringLiteral`, added the `lossy` field to indicate whether the `value` contains a lossy replacement character (U+FFFD). In codegen, print the raw string...

> > In [#9918](https://github.com/oxc-project/oxc/pull/9918), I made the following changes: > > In `StringLiteral`, added the `lossy` field to indicate whether the `value` contains a lossy replacement character (U+FFFD). > >...

> > Oh sorry, forgot to mention that we now have a `raw` field, or you can slice it from the source text. > > Oh, my bad! In that...

### Merge activity * **Nov 13, 12:40 AM EST**: The merge label '0-merge' was detected. This PR will be added to the [Graphite merge queue](https://app.graphite.dev/merges?org=oxc-project&repo=oxc) once it meets the requirements....

@camc314 can you merge after testing this PR manually?

Close as stale. Feel free to comeback when ts is updated.

Closed by https://github.com/vscode-icons/vscode-icons/pull/3665 Thank you @Sysix for working on the icons ❤️