Boshen
Boshen
Found another test case ``` !a || !b || !c || !d ``` ``` warning[[js/useSimplifiedLogicExpression](https://rome.tools/docs/lint/rules/useSimplifiedLogicExpression/)]: Logical expression contains unnecessary complexity. ┌─ main.js:1:1 │ 1 │ !a || !b || !c...
Found another case in [react-admin](https://github.com/marmelab/react-admin/blob/master/packages/ra-ui-materialui/src/layout/Menu.tsx#L53-L54) ``` error[SyntaxError]: Declarations inside of a `const` declaration may not have duplicates ┌─ react-admin/packages/ra-ui-materialui/src/layout/Menu.tsx:54:22 │ 53 │ .filter(name => resources[name].hasList) │ ---- `name` is first...
It's actually not about the explanation. If you look closely, Rome is currently reporting a separate "before it can reach this code" for every single node/identifier/statement. My suggestion is to...
I'm expecting a single error, and any mention of `async` context. The two error messages are understandable from the spec perspective, but from user perspective it's rather confusing. Also, the...
This normalization is actually [number-to-string](https://tc39.es/ecma262/#sec-numeric-types-number-tostring) from the spec. I think we can use https://crates.io/crates/ryu-js, it's from https://github.com/boa-dev/boa > Ryū-js is a fork of the [ryu](https://crates.io/crates/ryu) crate adjusted to comply to...
hmm ... number parsing hasn't been used anywhere yet, maybe this is the time? I'm afraid that any adhoc algorithm will eventually end up similar to the number-to-string algorithm. https://github.com/rome/tools/blob/a4702bacc973306453a01be4ad04a2c03104d376/crates/rome_js_syntax/src/expr_ext.rs#L366-L370
FYI yield / generator has the same problem 😉 You may wish to fix it next.
You may want to test your release script for this, `cargo workspaces` stopped working when I changed to this :-(
@alexander-akait For both test case (ESM array fallback and this one), it seems like we just need to abort the resolution in the exports field plugin. But I tried for...
@ycjcl868 can you check if you have `RUSTC_WRAPPER` env set to a stable rustc?