Boshen comments

Results 565 comments of


                                            Boshen

Advanced chunking seems to revert any treeshaking/minification

This blocks a user from adopting Rolldown in production. Ref ENG-342.

fix(minifier): collapse variables when `join_vars` option is `true`

closed by https://github.com/oxc-project/oxc/pull/6464

linter: API for working with the linter custom compiler

Consuming the linter via API is not planned.

Coworkers report that lint --fix will sometimes delete / empty / truncate a file.

Despite being fixed, we need an integration test to catch future regressions.

Coworkers report that lint --fix will sometimes delete / empty / truncate a file.

> @Boshen, do you think writing a 5s loop regression test is worth it? Probably, leave this to me, I'll think about this issue.

Coworkers report that lint --fix will sometimes delete / empty / truncate a file.

Added a test in https://github.com/oxc-project/oxc/pull/6747, the test checks the modified timestamp to ensure file is not written when no fix is applied.

perf(napi/parser): lazy load raw transfer deserializers

### Merge activity * **Apr 19, 10:12 AM EDT**: The merge label '0-merge' was detected. This PR will be added to the [Graphite merge queue](https://app.graphite.dev/merges?org=oxc-project&repo=oxc) once it meets the requirements....

Oxlint doesn't follow `extends` directive in .eslintrc.json

I'm in the process of setting up json schema, it will solve the discoverability issue. As for supporting `extends`, I think it's valuable so I'll keep this feature request open.

Oxlint doesn't follow `extends` directive in .eslintrc.json

> @Boshen I can implement the `extends` resolution; Last night I actually did some work on it; But it seems like we are changing the `ESLintConfig` load process which would...

feat(linter): generate schemas for rules (with documentation)

> I'm not sure what we want to do about configuration_schema.json, should we add a prepublish task to create it within oxlint? I'll take a look at this today.